Open
Conversation
alok1304
force-pushed
the
improve_search
branch
from
cd740e4 to
81655f3
Compare
Author
|
@pombredanne can you please review this PR : ) |
alok1304
force-pushed
the
improve_search
branch
5 times, most recently
from
6f45c07 to
d2062d3
Compare
1. Update stats wording after the search. 2. Search box only searches for the license key or license name. Reference: aboutcode-org#58 Signed-off-by: Alok Kumar <alokkumarjipura9973@gmail.com>
alok1304
force-pushed
the
improve_search
branch
from
d2062d3 to
72a7a9a
Compare
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@alok1304 thanks++ for looking into this, but note that this is just a repo with a generated static website, the console script (scancode-license-data) to generate this exists at https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/license_db.py and uses the templates at https://github.com/aboutcode-org/scancode-toolkit/tree/develop/src/licensedcode/templates.
So you have to make your changes there, This repo just holds the scripts and workflows to run a daily fetch from scancode-toolkit develop, build the static website and have this hosted at https://scancode-licensedb.aboutcode.org/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58
Task:
Linkscolumn #48I use the column-specific search API provided by DataTables. (source: https://datatables.net/reference/api/search())
Reference: #58
Also I attach my work in screenshot before and after.
We can clearly see that in 1st screenshot it shows Showing 1 to 376 of 376 licenses. On 2nd screenshot we see that it shows Showing 51 licenses. Also we can see that here license is 51 because we only search for license key and name, not for all.
For Task :
show search box on all pages, I tried I also add search box on all pages but the problem is that the search box on pages are not working when we search on it.